Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run dataclass plugin before checking type var bounds #12908

Merged
merged 1 commit into from
May 30, 2022

Conversation

JukkaL
Copy link
Collaborator

@JukkaL JukkaL commented May 30, 2022

The plugin may add attributes that are needed to perform the bound
check.

Fixes #12876.

The plugin may add attributes that are needed to perform the bound
check.

Fixes #12876.
@github-actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@JukkaL JukkaL merged commit b07018c into master May 30, 2022
@JukkaL JukkaL deleted the fix-dataclass-bound branch May 30, 2022 12:08
JukkaL added a commit that referenced this pull request Jun 1, 2022
The plugin may add attributes that are needed to perform the bound
check.

Fixes #12876.
@JukkaL JukkaL mentioned this pull request Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(regression: 0.960) Generic[Protocol] fails with dataclass
2 participants